Seyret Video Component
    Good Component - Badly coded., May 4, 2008 |
4 of 6 people find this review helpful:
Everything people have said about how good looking and feature-filled the component is are correct, but there are a few very obvious issues. (This relates to the most recent version at the time of writing - 0.2.7.9) They may only be of interest to the technically proficient, but they are still very important to all.
1. Although it is important to turn off notices and error messages in PHP for production purposes, it is vastly more important to ensure you have no errors or notices when developing - that is basic quality control. However, this has clearly not been done - errors and warnings abound, with many quite serious ones. We were forces to fix these before we could consider using this component, I encourage others to do the same. In house we are discussing branching this code to make the changes available, but we have so many OSI type projects we are not sure about taking on another.
2. Although comments appear in the code regarding PHP 5 compliance, the changes show a lack of understanding of PHP-5. I encourage the developers to take some time out and re-read the PHP5 specification. You cannot test PHP-5 issues using PHP-4 engine has is apparently been done when creating the code.
3. Only supports mysql engine not mysqli! Joomla supports both mysql and mysqli engines, even more databases are on the roadmap. This component breaks with the improved mysql engine and so forces users into using the much slower, more buggy, and more resource intensive mysql engine. A real shame. Again, we had to spend time fixing this. This is certainly not the only extension available that displays this problem. Come on devs, RTF(PHP and Joomla)M!
Overall a great idea, with good features, but poorly implemented. Think very carefully before deploying in a production environment.
|
|