ahotzler
Results 1 - 2 of 2
byahotzler, March 2, 2010
i like the module, because it is small and simple. It doesnt load code from other servers, like addthis, by default, which is good for german Data Protection Act.
But the module creates bad html output, the module code needs a cleanup:
1.) The module outputs html, head and body tag, this has nothing to do withit a module
2.) The module adds a link to a css file into the code, which also breaks XHTML Rules.
This code should be replaced with:
$document =& JFactory::getDocument();
$attribs = array('type' => 'text/css', 'media' => 'screen');
$document->addHeadLink(JRoute::_($path_to_css), 'stylesheet', 'rel', $attribs);
This way loads the css file the "joomla way"
3.) Some code isnt escaped via HTML Character Entities
Code cleanup would be done in 30 minutes. Please excuse my poor english.
Owner's reply
thx for the info, it will be done in the next version + some other improvements
and thank all ya'll for good reviews
byahotzler, October 7, 2009
1 hour later i finished the form and i am very happy with the results.
The only pain: The output breaks the XHTML compatibilty
